TOMEE-4584 - OpenIdAuthenticationMechanism store parameterMap#2472
TOMEE-4584 - OpenIdAuthenticationMechanism store parameterMap#2472
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request implements support for storing and restoring request parameters in the SavedRequest class, which is used by the OpenID authentication mechanism to preserve the original request during the authentication flow. This addresses TOMEE-4584 where request parameters were not being preserved during OpenID authentication redirects.
Changes:
- Added
parameterMapfield toSavedRequestclass for storing request parameters - Implemented parameter-related methods in the masked request wrapper
- Updated tests to verify parameter serialization/deserialization
- Added example servlet code to demonstrate parameter preservation after authentication
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| tomee/tomee-security/src/main/java/org/apache/tomee/security/http/SavedRequest.java | Added parameterMap field with getter/setter and implemented HttpServletRequest parameter methods in mask() wrapper |
| tomee/tomee-security/src/test/java/org/apache/tomee/security/http/SavedRequestTest.java | Updated serialization/deserialization tests to include parameterMap validation |
| examples/security-openid/src/main/java/org/superbiz/openid/SecuredServlet.java | Added code to display request parameters demonstrating the feature works |
| examples/security-openid/src/test/java/org/superbiz/openid/SecuredServletTest.java | Updated test expectations to verify parameters are preserved after authentication |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tomee/tomee-security/src/main/java/org/apache/tomee/security/http/SavedRequest.java
Outdated
Show resolved
Hide resolved
tomee/tomee-security/src/test/java/org/apache/tomee/security/http/SavedRequestTest.java
Show resolved
Hide resolved
tomee/tomee-security/src/main/java/org/apache/tomee/security/http/SavedRequest.java
Outdated
Show resolved
Hide resolved
tomee/tomee-security/src/main/java/org/apache/tomee/security/http/SavedRequest.java
Outdated
Show resolved
Hide resolved
tomee/tomee-security/src/main/java/org/apache/tomee/security/http/SavedRequest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Fixes TOMEE-4584