Skip to content

TOMEE-4584 - OpenIdAuthenticationMechanism store parameterMap#2472

Merged
jungm merged 2 commits intomainfrom
issue/TOMEE-4584
Mar 6, 2026
Merged

TOMEE-4584 - OpenIdAuthenticationMechanism store parameterMap#2472
jungm merged 2 commits intomainfrom
issue/TOMEE-4584

Conversation

@jungm
Copy link
Member

@jungm jungm commented Feb 19, 2026

Fixes TOMEE-4584

@jungm jungm requested a review from rzo1 February 19, 2026 07:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request implements support for storing and restoring request parameters in the SavedRequest class, which is used by the OpenID authentication mechanism to preserve the original request during the authentication flow. This addresses TOMEE-4584 where request parameters were not being preserved during OpenID authentication redirects.

Changes:

  • Added parameterMap field to SavedRequest class for storing request parameters
  • Implemented parameter-related methods in the masked request wrapper
  • Updated tests to verify parameter serialization/deserialization
  • Added example servlet code to demonstrate parameter preservation after authentication

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
tomee/tomee-security/src/main/java/org/apache/tomee/security/http/SavedRequest.java Added parameterMap field with getter/setter and implemented HttpServletRequest parameter methods in mask() wrapper
tomee/tomee-security/src/test/java/org/apache/tomee/security/http/SavedRequestTest.java Updated serialization/deserialization tests to include parameterMap validation
examples/security-openid/src/main/java/org/superbiz/openid/SecuredServlet.java Added code to display request parameters demonstrating the feature works
examples/security-openid/src/test/java/org/superbiz/openid/SecuredServletTest.java Updated test expectations to verify parameters are preserved after authentication

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@jungm jungm merged commit 02cd594 into main Mar 6, 2026
5 checks passed
@jungm jungm deleted the issue/TOMEE-4584 branch March 6, 2026 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants