Move the conversation renderer to Horizon 88e0110 - #42
Merged
Merged
Conversation
The Prompt tab's What it added mode said the request before was not among the loaded bodies whenever it had nothing to compare with. For every LangChain call, and for the first call of any chain, the request names no request before it, so nothing was missing. Horizon's renderer now says the request names none before it (apache/skywalking-horizon-ui#173), and the embedded copy moves to that commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the embedded conversation renderer to Horizon
88e0110, the newest commit on Horizon'smain. It picks up apache/skywalking-horizon-ui#173.The Prompt tab's What it added mode said "The request before this one is not among the loaded bodies" whenever it had nothing to compare with. For every LangChain call, and for the first call of any chain, the request names no request before it, so nothing was missing. It now says "This request names no request before it, so there is nothing to compare with." A request that names one the tab can't find keeps the old message.
internal/view/conversation-viewis rebuilt withtools/conversation-view.sh update 88e0110add7c9d592e1dcf251a4eb6efb8c699a9. #173 is the only Horizon commit since the old pin (297f020) that touches the renderer or the design tokens.Checked
make conversation-view-checkandmake checkpass.