[fix][client] Return client close promise#457
Open
nassero wants to merge 1 commit intoapache:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #456
Motivation
Awaiting
client.close()will not properly wait for the client to close before continuing.Modifications
Return the promise in the
closemethod.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-neededFixes existing interaction
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)