Core: Add Java doc for the class PolarisPrivilege#3757
Open
flyrain wants to merge 1 commit intoapache:mainfrom
Open
Core: Add Java doc for the class PolarisPrivilege#3757flyrain wants to merge 1 commit intoapache:mainfrom
flyrain wants to merge 1 commit intoapache:mainfrom
Conversation
adutra
reviewed
Feb 13, 2026
| * | ||
| * <p>Alternative authorizer implementations such as the OPA-based authorizer may not use these | ||
| * privileges. They operate at the {@link org.apache.polaris.core.auth.PolarisAuthorizableOperation} | ||
| * level and delegates all privilege/permission logic to external PDPs. |
Contributor
There was a problem hiding this comment.
Suggested change
| * level and delegates all privilege/permission logic to external PDPs. | |
| * level and delegate all privilege/permission logic to external PDPs. |
dimas-b
reviewed
Feb 14, 2026
| /** | ||
| * Enumerates the privileges used by the built-in RBAC authorizer ({@link | ||
| * org.apache.polaris.core.auth.PolarisAuthorizerImpl}). These privileges are granted to roles and | ||
| * checked against securables during authorization. |
Contributor
There was a problem hiding this comment.
nit: "securable" is not a common term (not in my experience)... It might be good to define it or link to where it is defined, or rephrase using more common terms.
| * org.apache.polaris.core.auth.PolarisAuthorizerImpl}). These privileges are granted to roles and | ||
| * checked against securables during authorization. | ||
| * | ||
| * <p>Alternative authorizer implementations such as the OPA-based authorizer may not use these |
Contributor
There was a problem hiding this comment.
nit: While this statement is valid, is it relevant to this class? Why should the reader be concerned with OPA in the context of PolarisPrivilege? The paragraph above already scopes it down to the Internal Authorizer 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To clarify PolarisPrivilege may only needed by the built-in RBAC
Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)