[core] Improve row id reassign retry reuse#8506
Draft
leaves12138 wants to merge 9 commits into
Draft
Conversation
9408a9b to
a999b5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
DataEvolutionRowIdReassignercan lose a commit race when a normal append commits a newer snapshot between planning andreplaceManifestList. Previously the next reassignment invocation had to start the manifest read work from scratch.Changes
replaceManifestListconflicts up to three times in the same reassignment call.nextRowIdon every retry to avoid row-id range overlap with concurrent appends.nextRowId.Tests
mvn -pl paimon-core spotless:applymvn -pl paimon-core -am -Pfast-build -DfailIfNoTests=false -DwildcardSuites=none -Dtest=DataEvolutionRowIdReassignerTest#testReassignRetriesWithLatestNextRowIdAfterConcurrentAppend testmvn -pl paimon-core -am -DfailIfNoTests=false -DwildcardSuites=none -Dtest=DataEvolutionRowIdReassignerTest testgit diff --check