Skip to content

[python] Support batch size for blob read#8502

Merged
JingsongLi merged 10 commits into
apache:masterfrom
discivigour:p/blobBatch
Jul 10, 2026
Merged

[python] Support batch size for blob read#8502
JingsongLi merged 10 commits into
apache:masterfrom
discivigour:p/blobBatch

Conversation

@discivigour

@discivigour discivigour commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Purpose

This pr restricts the reading of blob data in batches according to batch size.

Tests

  • test_blob_fallback_batch_reader_respects_batch_size
  • test_blob_fallback_batch_reader_reuses_version_readers

@discivigour discivigour marked this pull request as ready for review July 8, 2026 05:27
self._returned = False
self._readers: List[RecordBatchReader] = []
self._batch_size = max(1, batch_size)
# TODO: This path still materializes all target row ids and per-file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just do it?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I will do it.

@JingsongLi

Copy link
Copy Markdown
Contributor

+1

@JingsongLi JingsongLi merged commit 25a3b5a into apache:master Jul 10, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants