Add IVF_RQ query bits and format reservations#56
Merged
Conversation
leaves12138
approved these changes
Jul 9, 2026
leaves12138
left a comment
There was a problem hiding this comment.
Looks good to me. I reviewed the IVF_RQ query_bits API paths, format field validation, and language bindings; the Rust workspace tests, rustfmt check, and clippy all passed locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds IVF_RQ/RaBitQ support with a search-time query_bits tuning knob and reserves IVF_RQ v1 format fields for future multi-bit codes. Defaults remain conservative: query_bits=0 keeps the existing float-query path, and writers still emit 1-bit stored codes.
Changes
Testing
Notes
Current multi-bit storage is intentionally format-reserved only. Writers still produce num_bits=1 with no optional sections, so this PR does not enable multi-bit RQ by default.