HDDS-14555. [Recon] Clarify Open Key Bytes breakdown in Cluster Capacity page#9705
Conversation
priyeshkaratha
force-pushed
the
HDDS-14555
branch
from
a6d95f9 to
cc88f80
Compare
priyeshkaratha
changed the title
...ne/recon/src/main/resources/webapps/recon/ozone-recon-web/src/v2/pages/capacity/capacity.tsx
Outdated
Show resolved
Hide resolved
devabhishekpal
left a comment
devabhishekpal
left a comment
There was a problem hiding this comment.
Thanks for the patch @priyeshkaratha.
Overall the UI changes looks good to me, one minor comment, please take a look.
Could you also attach the UI screenshots in the PR description?
An also update the test description that the java patch was tested with Unit tests? since the tests got modified
|
@devabhishekpal Thanks for reviewing changes. I have addressed your comments. Please have a look again. |
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/api/db.json
Outdated
Show resolved
Hide resolved
priyeshkaratha
force-pushed
the
HDDS-14555
branch
from
981b862 to
1176a68
Compare
priyeshkaratha
force-pushed
the
HDDS-14555
branch
from
1176a68 to
5801f25
Compare
ArafatKhan2198
left a comment
ArafatKhan2198
left a comment
There was a problem hiding this comment.
Thanks for the changes @priyeshkaratha mostly looks good to me.
Some minor comments -
...ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/StorageDistributionEndpoint.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/types/OpenKeyBytesInfo.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/types/OpenKeyBytesInfo.java
Outdated
Show resolved
Hide resolved
| assertEquals(0, storageResponse.getUsedSpaceBreakDown().getOpenKeyBytes().getTotalOpenKeyBytes()); | ||
| assertEquals(0, storageResponse.getUsedSpaceBreakDown().getOpenKeyBytes().getMultipartOpenKeyBytes()); | ||
| assertEquals(0, storageResponse.getUsedSpaceBreakDown().getOpenKeyBytes().getOpenKeyAndFileBytes()); |
There was a problem hiding this comment.
The only test covering this is the integration test which only asserts all-zero values. There's no test that verifies the openKeyAndFileBytes and multipartOpenKeyBytes are correctly split (e.g., non-zero MPU size is correctly put in multipartOpenKeyBytes and not added to openKeyAndFileBytes).
There was a problem hiding this comment.
I have already ticket created for missing test cases. Because creating open key is tricky
https://issues.apache.org/jira/browse/HDDS-13968
There was a problem hiding this comment.
I updated same PR with adding openkeys and mpu keys. But more areas will be covered by above mentioned Jira
...ne/recon/src/main/resources/webapps/recon/ozone-recon-web/src/v2/pages/capacity/capacity.tsx
Outdated
Show resolved
Hide resolved
| <Tag color='red'>{filesize(selectedDNDetails.minimumFreeSpace, {round: 1})}</Tag> | ||
| Remaining | ||
| <Tag color='green'>{filesize(selectedDNDetails.remaining, { round: 1})}</Tag> |
There was a problem hiding this comment.
Red for Open Key/File Bytes and green for Multipart Key Bytes is arbitrary red conventionally signals a warning/error. The unusedSpaceBreakdown uses red for minimum free space (a constraint) which is semantically justified.
Here neither value has a warning connotation. Use neutral colours (e.g., blue/orange)
| } | ||
|
|
||
| .ant-popover-inner{ | ||
| .datanodes-container .ant-popover-inner { |
There was a problem hiding this comment.
What is the use of this change?
There was a problem hiding this comment.
this style overriding position of popover globally which is causing layout issues. Ideally it should be handled for particular classes.
|
@ArafatKhan2198 Thanks for the feedbacks. I have addressed all the comments. |
ArafatKhan2198
left a comment
ArafatKhan2198
left a comment
There was a problem hiding this comment.
Thanks for the taking care of the comments @priyeshkaratha
LGTM +1
3 participants
What changes were proposed in this pull request?
This pull request enhances the Apache Ozone Recon UI by providing a more detailed breakdown of "Open Key Bytes" on the Cluster Capacity page. Previously, only a single aggregated value was displayed. The changes introduce a new data structure in the backend to differentiate between "Open Key/File Bytes" and "Multipart Key Bytes," which is then exposed via the Recon API and presented to users in an informative tooltip on the frontend. This improvement offers greater transparency and clarity regarding storage utilization related to open keys.
What is the link to the Apache JIRA
HDDS-14555
How was this patch tested?
Tested API change using updated unit test cases.
Tested UI manually.