ORC-1662: [C++] Upgrade protobuf to 3.21.12#1857
Open
ffacs wants to merge 3 commits intoapache:mainfrom
Open
Conversation
Member
|
Thanks for the PR! Unfortunately the new protobuf version is not compatible to compile libhdfspp. Let me investigate this. |
Member
|
Update: I tried to upgrade libhdfspp. But unfortunately, I ran this command https://github.com/apache/orc/blob/main/c%2B%2B/libs/libhdfspp/pull_hdfs.sh#L25 without check. It wiped out my current directory (which is the root user profile). |
Member
|
Oh, too bad for the accident. |
dongjoon-hyun
added a commit
that referenced
this pull request
Feb 23, 2026
### What changes were proposed in this pull request? This PR aims to remove HDFS support code from Apache ORC repository. ### Why are the changes needed? Apache ORC 2.0.1 deprecated HDFS Support to address the following issues. - #1885 - #1857 - #2134 ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: `Gemini 3.1 Pro (High)` on `Antigravity` This closes #2136 . Closes #2544 from dongjoon-hyun/ORC-2102. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
|
Could you rebase this PR, @ffacs ? |
Guard alias creation for protobuf::libprotobuf and protobuf::protoc to avoid duplicate target errors when Protobuf >= 3.21 already exports them. Also mark protobuf headers as SYSTEM to suppress compiler warnings from protobuf code. Co-authored-by: Cursor <cursoragent@cursor.com>
Align the meson build protobuf version with the CMake build (3.21.12) using the latest wrapdb patch (3.21.12-5). Co-authored-by: Cursor <cursoragent@cursor.com>
ffacs
force-pushed
the
bump_protobuf_version
branch
from
f9737e2 to
91a336a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Upgrade protobuf to 3.21.12
Why are the changes needed?
To fix compilation failure on vs2022
How was this patch tested?
UT passed
Was this patch authored or co-authored using generative AI tooling?
NO