MINIFICPP-2752 - Register processors one-by-one#2150
Closed
adamdebreceni wants to merge 4 commits intoapache:mainfrom
Closed
MINIFICPP-2752 - Register processors one-by-one#2150adamdebreceni wants to merge 4 commits intoapache:mainfrom
adamdebreceni wants to merge 4 commits intoapache:mainfrom
Conversation
8 tasks
martinzink
added a commit
to martinzink/nifi-minifi-cpp
that referenced
this pull request
Mar 30, 2026
8 tasks
szaszm
reviewed
Apr 9, 2026
This was referenced Apr 9, 2026
2c5414a to
be71b24
Compare
szaszm
reviewed
Apr 10, 2026
There was a problem hiding this comment.
Pull request overview
Refactors the stable C extension initialization flow so extensions are created once and then processors can be registered incrementally, aligning better with extensions that discover/register processors dynamically.
Changes:
- Updates the stable C API to introduce
MinifiExtensionContext, changeMinifiCreateExtensionto return an extension handle, and addMinifiRegisterProcessor. - Adjusts core extension initialization to pass an extension context into
MinifiInit*Extensionentrypoints and updates built-in extensions/loaders accordingly. - Updates Windows export definitions, integration tests, and the extensions guide example for the new registration model.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| minifi-api/minifi-c-api.def | Exports new MinifiRegisterProcessor symbol on Windows. |
| minifi-api/include/minifi-c/minifi-c.h | C API signature updates: add MinifiExtensionContext, change create signature, add register API, update config access signature. |
| libminifi/src/minifi-c.cpp | Implements new MinifiCreateExtension return type + MinifiRegisterProcessor, updates MinifiConfigGet to use context. |
| libminifi/src/core/extension/Extension.cpp | Switches extension init entrypoint to MinifiExtensionContext* and wires context-based creation/config access. |
| libminifi/include/core/extension/Extension.h | Introduces Extension::Context and changes info access. |
| extensions/llamacpp/processors/ExtensionInitializer.cpp | Updates C extension init to create once + register processor. |
| extensions/ExtensionInitializer.cpp | Updates generic C++ extension init signature to take context. |
| extensions/opencv/OpenCVLoader.cpp | Updates C++ extension init signature to take context. |
| extensions/python/pythonloader/PyProcLoader.cpp | Uses context-based MinifiConfigGet and updated init signature. |
| extensions/python/pythonlibloader/PythonLibLoader.cpp | Uses context-based MinifiConfigGet and updated init signature. |
| extensions/sftp/SFTPLoader.cpp | Updates C++ extension init signature to take context. |
| extension-framework/include/utils/ExtensionInitUtils.h | Updates helper wrapper to call new create signature. |
| libminifi/test/integration/extension-verification-test/ExtensionVerificationTests.cpp | Updates custom create hook signature used by tests. |
| libminifi/test/integration/extension-verification-test/CreateNotCalled.cpp | Updates C extension init signature for “create not called” test. |
| libminifi/test/integration/extension-verification-test/CppApiExtension.cpp | Updates C++ extension init signature + create info initialization. |
| libminifi/test/integration/extension-verification-test/CApiExtension.cpp | Updates C extension init signature + create info initialization. |
| Extensions.md | Updates C-extension example to create once and register processors one-by-one. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
02c006c to
b295553
Compare
lordgamez
approved these changes
Apr 17, 2026
szaszm
approved these changes
Apr 21, 2026
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on
Used by
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.