MINIFICPP-2644 Add proxy controller service support for AWS and Azure processors by lordgamez · Pull Request #2045 · apache/nifi-minifi-cpp

lordgamez · 2025-10-09T11:19:41Z

https://issues.apache.org/jira/browse/MINIFICPP-2644

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?

For code changes:

If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE file?
If applicable, have you updated the NOTICE file?

For documentation related changes:

Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

lordgamez · 2025-10-09T12:56:31Z

The clang tidy errors are already fixed in #2040

Copilot

Pull Request Overview

This PR adds proxy controller service support for AWS and Azure processors, allowing centralized proxy configuration management through a new ProxyConfigurationService controller service instead of requiring individual proxy properties on each processor.

Introduces a new ProxyConfigurationService controller service for centralized proxy configuration management
Updates AWS and Azure processors to support using the proxy configuration service as an alternative to individual proxy properties
Adds comprehensive test coverage for the new proxy configuration service functionality

Reviewed Changes

Copilot reviewed 36 out of 36 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
minifi-api/include/minifi-cpp/controllers/ProxyConfigurationServiceInterface.h	Interface definition for proxy configuration service
libminifi/include/controllers/ProxyConfigurationService.h	Implementation header for proxy configuration service
libminifi/src/controllers/ProxyConfigurationService.cpp	Core implementation of proxy configuration service
libminifi/test/unit/ProxyConfigurationServiceTests.cpp	Unit tests for proxy configuration service
extensions/azure/processors/*	Azure processor base classes updated to support proxy service
extensions/azure/storage/*	Azure storage clients updated to handle proxy configuration
extensions/azure/tests/*	Test files updated to include proxy service test cases
extensions/aws/processors/AwsProcessor.*	AWS processor updated to support proxy configuration service
extensions/aws/tests/*	AWS test files updated to test both proxy service and direct properties
docker/test/integration/*	Integration test support for proxy configuration service
PROCESSORS.md	Documentation updated to reflect new proxy configuration service property
CONTROLLERS.md	Documentation for the new ProxyConfigurationService controller

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

lordgamez · 2025-10-13T07:12:04Z

The issues listed in the clang tidy checks are fixed in the following PR: #2040

szaszm · 2026-02-23T12:59:20Z

  std::string file_system_name;
  std::string directory_name;
  std::optional<uint64_t> number_of_retries;
+  std::optional<minifi::controllers::ProxyConfiguration> proxy_configuration;


Instead of an optional member, it could default to type==DIRECT, which means no proxy. That would make one more impossible state unrepresentable, which is considered a best practice nowadays.

I'm not sure I'm convinced about this. What do you mean by "one more impossible state unrepresentable"? It seem a bit unintuitive to me. When the user adds a proxy controller service their intention is to use a proxy, if they do not want to use a proxy they should not add a service at all. What would be the benefit of adding a proxy service and configure it to not to use a proxy?

Updated in 8890e9f

We can remove the optional member now

… processors

szaszm · 2026-04-20T15:38:29Z

+  std::optional<uint16_t> proxy_port;
+  std::optional<std::string> proxy_user;
+  std::optional<std::string> proxy_password;


I'd make proxy_port a raw uint16_t, it's always going to be set anyway, or we can use 0 as a default value if need be. Also let's move the username + password into a separate struct with not optional string fields, and have an optional here.

szaszm · 2026-04-23T12:52:29Z

  std::string file_system_name;
  std::string directory_name;
  std::optional<uint64_t> number_of_retries;
+  std::optional<minifi::controllers::ProxyConfiguration> proxy_configuration;


We can remove the optional member now

szaszm · 2026-04-23T12:56:32Z

+  plan_->setProperty(proxy_configuration_service, "Proxy Server Port", "1234");
+  plan_->setProperty(proxy_configuration_service, "Proxy User Name", "username");
+  plan_->setProperty(proxy_configuration_service, "Proxy User Password", "password");
+  plan_->setProperty(proxy_configuration_service, "Proxy Type", "HTTPS");


HTTPS is no longer supported, we should change it to HTTP

szaszm · 2026-04-23T13:51:15Z

-std::unique_ptr<Azure::Storage::Files::DataLake::DataLakeFileSystemClient> AzureDataLakeStorageClient::createClient(
-    const AzureStorageCredentials& credentials, const std::string& file_system_name, std::optional<uint64_t> number_of_retries) {
+std::unique_ptr<Azure::Storage::Files::DataLake::DataLakeFileSystemClient> AzureDataLakeStorageClient::createClient(const AzureStorageCredentials& credentials,
+    const std::string& file_system_name, std::optional<uint64_t> number_of_retries, const std::optional<minifi::controllers::ProxyConfiguration>& proxy_configuration) {


An optional non-owning reference can be more simply represented as a pointer

Suggested change

const std::string& file_system_name, std::optional<uint64_t> number_of_retries, const std::optional<minifi::controllers::ProxyConfiguration>& proxy_configuration) {

const std::string& file_system_name, std::optional<uint64_t> number_of_retries, minifi::controllers::ProxyConfiguration* const proxy_configuration) {

lordgamez force-pushed the MINIFICPP-2644_aws_azure branch from 93b6f3b to a1a832e Compare October 9, 2025 12:35

lordgamez requested a review from Copilot October 9, 2025 12:56

Copilot AI reviewed Oct 9, 2025

View reviewed changes

Comment thread PROCESSORS.md

Comment thread PROCESSORS.md

Comment thread PROCESSORS.md

Comment thread PROCESSORS.md

lordgamez marked this pull request as ready for review October 13, 2025 07:15

lordgamez force-pushed the MINIFICPP-2644_aws_azure branch from a1a832e to cd31ed2 Compare October 18, 2025 12:50

szaszm reviewed Nov 13, 2025

View reviewed changes

Comment thread CONTROLLERS.md Outdated

Comment thread minifi-api/include/minifi-cpp/controllers/ProxyConfigurationServiceInterface.h Outdated

lordgamez force-pushed the MINIFICPP-2644_aws_azure branch 2 times, most recently from 12e4262 to ee61c70 Compare January 10, 2026 08:56

fgerlits reviewed Jan 12, 2026

View reviewed changes

Comment thread extensions/aws/processors/AwsProcessor.cpp Outdated

Comment thread CONTROLLERS.md Outdated

Comment thread libminifi/include/controllers/ProxyConfigurationService.h

lordgamez marked this pull request as draft January 14, 2026 16:31

lordgamez force-pushed the MINIFICPP-2644_aws_azure branch from b361c6f to ee61c70 Compare January 14, 2026 16:32

lordgamez force-pushed the MINIFICPP-2644_aws_azure branch 2 times, most recently from 530067c to fa7ded8 Compare February 18, 2026 16:19

lordgamez marked this pull request as ready for review February 18, 2026 16:20

fgerlits approved these changes Feb 18, 2026

View reviewed changes

szaszm reviewed Mar 2, 2026

View reviewed changes

lordgamez force-pushed the MINIFICPP-2644_aws_azure branch 2 times, most recently from f70ac21 to 99207e1 Compare March 10, 2026 16:02

martinzink approved these changes Mar 25, 2026

View reviewed changes

fgerlits mentioned this pull request Mar 26, 2026

MINIFICPP-2644 Add proxy controller service support for GCP processors #2112

Open

8 tasks

szaszm self-requested a review April 13, 2026 11:40

lordgamez added 7 commits April 14, 2026 14:13

MINIFICPP-2644 Add proxy controller service support for AWS and Azure…

af02930

… processors

Clang tidy fix

109efea

Review update

8f2684a

Fix after rebase

89e0415

Review update

e968c14

Add HTTPS proxy support for AWS processors

bdfc7f9

Review update

10c807b

lordgamez added 2 commits April 14, 2026 14:13

Review update

1affabe

Fix after rebase

3328292

lordgamez force-pushed the MINIFICPP-2644_aws_azure branch 2 times, most recently from fd4984e to bbefc33 Compare April 15, 2026 13:01

Review update

8890e9f

lordgamez force-pushed the MINIFICPP-2644_aws_azure branch from bbefc33 to 8890e9f Compare April 15, 2026 13:03

lordgamez added 2 commits April 15, 2026 17:19

Remove old files

ab4bc97

Fix clang tidy issues

e8fc1c8

szaszm reviewed Apr 20, 2026

View reviewed changes

szaszm reviewed Apr 23, 2026

View reviewed changes

	const std::string& file_system_name, std::optional<uint64_t> number_of_retries, const std::optional<minifi::controllers::ProxyConfiguration>& proxy_configuration) {
	const std::string& file_system_name, std::optional<uint64_t> number_of_retries, minifi::controllers::ProxyConfiguration* const proxy_configuration) {

Conversation

lordgamez commented Oct 9, 2025

For all changes:

For code changes:

For documentation related changes:

Note:

Uh oh!

lordgamez commented Oct 9, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lordgamez commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

szaszm Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

lordgamez Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

lordgamez Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

szaszm Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

szaszm Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

szaszm Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

szaszm Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

szaszm Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lordgamez commented Oct 13, 2025 •

edited

Loading

lordgamez Apr 15, 2026 •

edited

Loading