Repository navigation
ci: cap the test job at 30 minutes - #58
Conversation
|
I fixed the root cause of these long hanging macos tests in a separate PR, but this is a good change just in case something similar happens in the future. Rationalizing in the comment is not necessary. |
|
15 timeout might not be valid anymore. We added some more tests in #77 and it takes almost (sometimes more) 15 minutes. https://github.com/apache/mina/actions/runs/37960280693/job/113921075461 Ubuntu runners seem to be a lot slower than Windows / Mac. |
|
Hi @the-thing, The slow run on Linux is probably due to its TCP/IP stack, fixed in #93 by adding That said, what would a reasonable timeout be? 30 minutes? |
The test job had no timeout, so a hung or deadlocked test ran until GitHub's 6-hour default before failing. Cap the job at 30 minutes to prevent such runaway builds. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
6a01a1f to
65a7349
Compare
|
Ubuntu/debian seems to have a weird way to handle small packet of data. Enabling the NAGLE algorithm does not seems necessary those days, but well, the test you have modified sends 4096 packet of 4 bytes, so I guess it takes a bit of time. Setting the timeout to 30mins sounds reasonable. |
|
Too late.
|
|
Yeah... But the next one will be ok ;-) |
What
Adds a job-level
timeout-minutes: 30to thetestjob in the Java CI workflow.Why
The
testjob had no timeout, so a hung or deadlocked test runs until GitHub's 6-hour default before the job fails (as seen on #57, where a test got into a deadlock). The purpose of the cap is only to prevent such runaway builds, so 30 minutes leaves ample margin for the slowest matrix cells. The current slowness of the Ubuntu jobs is addressed separately in #93.The cap is job-level, so it applies to every OS/JDK matrix combination. When it fires, the
if: always()"Upload test reports" step still runs, preserving whatever surefire output exists to help locate the hang.🤖 Generated with Claude Code