[MWRAPPER-117] added distributionSha512Sum and wrapperSha512Sum#398
Open
erik-meuwese-topicus wants to merge 1 commit intoapache:masterfrom
Open
[MWRAPPER-117] added distributionSha512Sum and wrapperSha512Sum#398erik-meuwese-topicus wants to merge 1 commit intoapache:masterfrom
erik-meuwese-topicus wants to merge 1 commit intoapache:masterfrom
Conversation
…erification with SHA-512 since Maven only publishes the SHA-512 checksum and not the SHA-256 checksum
Is this potential deprecation tracked? I ask because it may be lost and I wonder if we can add that as a log as part of this change? |
This link confused me because that's about the wrapper. I think that you meant to share something like https://repo1.maven.org/maven2/org/apache/maven/apache-maven/3.9.12/ where each distribution after 3.9.0 has a |
elharo
changed the title
elharo
requested changes
Jan 31, 2026
| exit 1 | ||
| fi | ||
| if [ $distributionSha512Result = false ]; then | ||
| echo "Error: Failed to validate Maven distribution SHA-512, your Maven distribution might be compromised." >&2 |
| distributionSha512Result=true | ||
| fi | ||
| else | ||
| echo "Checksum validation was requested but neither 'sha512sum' or 'shasum' are available." >&2 |
| fi | ||
| else | ||
| echo "Checksum validation was requested but neither 'sha512sum' or 'shasum' are available." >&2 | ||
| echo "Please install either command, or disable validation by removing 'distributionSha512Sum' from your maven-wrapper.properties." >&2 |
| $distributionSha512Sum = (Get-Content -Raw "$scriptDir/.mvn/wrapper/maven-wrapper.properties" | ConvertFrom-StringData).distributionSha512Sum | ||
| if ($distributionSha512Sum) { | ||
| if ($USE_MVND) { | ||
| Write-Error "Checksum validation is not supported for maven-mvnd. `nPlease disable validation by removing 'distributionSha512Sum' from your maven-wrapper.properties." |
| } | ||
| Import-Module $PSHOME\Modules\Microsoft.PowerShell.Utility -Function Get-FileHash | ||
| if ((Get-FileHash "$TMP_DOWNLOAD_DIR/$distributionUrlName" -Algorithm SHA512).Hash.ToLower() -ne $distributionSha512Sum) { | ||
| Write-Error "Error: Failed to validate Maven distribution SHA-512, your Maven distribution might be compromised. If you updated your Maven version, you need to update the specified distributionSha512Sum property." |
Member
|
Windows seems failing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added distributionSha512Sum and wrapperSha512Sum for verification with SHA-512 since Maven only publishes the SHA-512 checksum and not the SHA-256 checksum.
The wrapper SHA-512 is pulished on https://maven.apache.org/tools/wrapper/download.cgi
The distribution SHA-512 is published on https://maven.apache.org/download.cgi
The SHA-256 option is still available for backward compatibility. However this could be marked deprecated and removed in future versions since Maven doesn't publish the SHA-256 checksums.
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.