Repository navigation
Conversation
The worker bundle was emitted as dist/workers/filesystem-worker.js, so Node walked up to the nearest package.json to decide the module type. Inside the Windows AppContainer sandbox that read is denied, and the worker crashed at launch with ERR_INVALID_PACKAGE_CONFIG. The windows_sandbox_w0_protocol job has failed on main because of it. An .mjs bundle is ESM by extension, so Node never performs the lookup. The build and desktop copy scripts now take the file name from FILESYSTEM_WORKER_BUNDLE_NAME so the producer cannot drift from the resolver; packaging verifiers keep literal paths because they check the shipped layout independently. Split out of #5969, which carries the same rename. Generated-by: Claude Code
4 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
windows_sandbox_w0_protocolhas failed on everymainrun since at least 2026-09-30. Two of the four tests infilesystem-worker-windows-smoke.test.jscrash the worker at launch:The worker bundle was emitted as
dist/workers/filesystem-worker.js, so Node walks up to the nearestpackage.jsonto decide the module type. The AppContainer sandbox denies that read. Emitting the bundle asfilesystem-worker.mjsmakes it ESM by extension and removes the lookup.FILESYSTEM_WORKER_BUNDLE_NAMEstays the authority: the esbuild script and the desktop resource copy now import it from the runtime build instead of repeating the literal, so the producer cannot drift from the resolver. Packaging verifiers (verify-packaged-app,verify-macos-dmg,verify-windows-sandbox-e2e,windows-smoke, the release CLI packager and smoke) keep literal paths because they check the shipped layout on their own.The same rename is part of #5969; this splits it out so W0 can go green without waiting for that feature.
Refs #5969
Verification
npm --workspace @maka/runtime run buildemitsdist/workers/filesystem-worker.mjs;node apps/desktop/scripts/copy-runtime-filesystem-worker.mjscopies it toresources/workers/filesystem-worker.mjs.packages/runtime:node --testoverfilesystem-worker*,linux-sandbox*,macos-seatbelt*tests: 126 pass, 8 skipped (platform-gated), 0 fail.ci-test-plan,ci-workflow-policy,desktop-release-targets,desktop-nightly,product-release,source-legal-inventory,verify-windows-harness,verify-packaged-app*,windows-package-source-closure,release-cli-*): 276/276 pass.npm run format,npm run lint: clean.windows_sandbox_w0_protocolrun.AI use
Select exactly one:
Tool(s) and scope: Claude Code located the references, made the rename, ran the checks, and drafted this description.
Checklist
Does this PR entail a change in behavior?