Change binary/source distro names to prefix with apache - #255
Merged
Merged
Conversation
lresende
force-pushed
the
fix-package-name
branch
2 times, most recently
from
September 10, 2026 08:29
4e5fb20 to
84cbe43
Compare
Apache release policy expects distribution artifacts to carry the full project name. The binary and source packages, their dist subdirectories and the top-level directory inside each archive now use an apache-toree prefix. The pip packages already ship under both the toree and the apache-toree names and are unchanged. publish-pip uploads both pip packages instead of only the toree one, and the audit target verifies dist/apache-toree-pip, which it previously skipped. verify-release matches the new artifact names and fails when a directory holds no artifacts at all, so an audit can no longer report success without having verified anything. release-build.sh reports the tag it created and says explicitly when a dry run skips the push. Also updates Scala to 2.12.20 and 2.13.15, and comments out the AddJar system test, whose fixture jar at home.apache.org now returns 404.
The ASF deprecated MD5 for release distribution, so sign-file no longer generates .md5, verify-release no longer requires it, and the sign targets drop it from their outputs and prerequisites. The find in verify-release still excludes *.md5 so that a stale file left by an earlier build cannot be mistaken for a release artifact. release-build.sh now stages the binary and source artifacts under apache-toree rather than toree, matching their new names. The toree-pip directory keeps its name because it stages the package that is published to PyPI as toree. Commenting out test_statements_stdout left test_scala_stdout iterating an attribute that no longer existed, so the test raised AttributeError instead of being skipped. Restore the data and skip the method, with the reason recorded alongside it.
lresende
force-pushed
the
fix-package-name
branch
from
September 11, 2026 16:20
0fb8038 to
4b3da4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Apache release policy expects distribution artifacts to carry the full project
name. This renames the binary and source distributions, their
distsubdirectories, and the top-level directory inside each archive to use an
apache-toreeprefix.toree-<VERSION>-bin.tar.gzapache-toree-<VERSION>-bin.tar.gztoree-<VERSION>-src.tar.gzapache-toree-<VERSION>-src.tar.gztoree-<VERSION>/apache-toree-<VERSION>/toree-<VERSION>-src/apache-toree-<VERSION>-src/dist/toree-{bin,src}dist/apache-toree-{bin,src}The pip packages already ship under both the
toreeandapache-toreenamesand are unchanged.
Alongside the rename:
publish-pipuploads both pip packages instead of only thetoreeone. Itneeds two different container working directories, so the single
$(DOCKER)invocation is split into two.
auditnow passesdist/apache-toree-piptoverify-release, which itpreviously skipped entirely.
verify-releasematches the new artifact names, and fails when a directorycontains no artifacts at all. Previously the per-file loop set
failureonly from inside its body, so an empty or non-existent directory produced a
successful audit that had verified nothing.
release-build.shechoes the tag it created and says explicitly when a dryrun skips the push.
Also updates Scala to 2.12.20 and 2.13.15, and comments out the AddJar system
test — its fixture jar at
home.apache.org/~lresende/toree/TestJar.jarnowreturns 404. That test should come back once the jar is hosted somewhere
durable.
Testing
CI covers the rename:
make clean releasebuilds the renamed bin and srctarballs on all four Java/Scala combinations.
CI does not run
make audit, soverify-releasewas exercised by handagainst fixture directories, using a throwaway GPG keyring:
ERROR: No release artifacts foundtoree-*andapache-toree-*in one directory.asc/.md5/.sha512