Conversation
Member
Author
|
#207 is opened to address "status" issue. |
etc/bin/run.sh resolves the kernel assembly by name from the lib directory next to it, and the jar is now named apache-toree-assembly-<version>.jar, so the lookup matched nothing and spark-submit failed with "Failed to load class org.apache.toree.Main".
Toree declared protocol 5.0 in message headers and in kernel_info_reply, so jupyter_kernel_test applies its legacy envelope checks to every message it receives and rejects the msg_id/msg_type keys that jupyter_client 7+ adds when deserializing messages. 5.2 is the lowest revision not subject to those checks, which lets the kernel info, completion, is_complete and execution tests reach the reply contents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jupyter_kernel_test seems revived, try first.
Some conclusions:
Currently, Toree implementation is based on Jupyter 5.0 protocol, and the latest version is 5.4.
The
jupyter_kernel_testseems to become stricter now. e.g.the docs say
But Toree's implementation does not satisfy such restriction. e.g. the
KernelInfoReplydoes not contain "status", so that it will be failed withSo we need to revise the protocol definition and our implementation before enabling the
system-test.