Repository navigation
Conversation
stevenzwu
force-pushed
the
geospatial-bound-struct-like
branch
from
October 6, 2026 06:40
5c0e921 to
b90d70e
Compare
stevenzwu
commented
Oct 6, 2026
| private static Object copyBound(Object bound) { | ||
| if (bound instanceof byte[] bytes) { | ||
| return copyOf(bytes); | ||
| } else if (bound instanceof StructLike struct) { |
Contributor
Author
There was a problem hiding this comment.
I removed the usage PartitionData and updated serialization test in TestFieldStatsStruct so that we can remove this copy branch.
stevenzwu
force-pushed
the
geospatial-bound-struct-like
branch
from
October 7, 2026 04:28
0285f3d to
5cb995d
Compare
Materialize v4 manifest geometry and geography lower and upper bounds as GeospatialBound so callers receive the bound type, and copy reused reader instances when field stats are copied. Generated-by: Grok 4.7 Co-authored-by: Cursor <cursoragent@cursor.com>
Geo field stats now store GeospatialBound, so copyBound no longer copies an arbitrary StructLike. GeospatialBound is Serializable, and the InternalData test read registers that type when the column is geometry or geography. Generated-by: Grok 4.7
stevenzwu
force-pushed
the
geospatial-bound-struct-like
branch
from
October 7, 2026 04:40
5cb995d to
3de75a4
Compare
Contributor
Author
|
cc @anoopj |
nastra
reviewed
Oct 9, 2026
| } | ||
|
|
||
| @Test | ||
| public void testStructLikeXYZM() { |
Contributor
There was a problem hiding this comment.
nit: maybe also test XYM and XYZ as the other tests do
nastra
reviewed
Oct 9, 2026
|
|
||
| private void registerGeospatialFieldStatsBounds( | ||
| InternalData.ReadBuilder readBuilder, Types.NestedField fieldStats) { | ||
| Types.NestedField tableField = tableSchema.findField(StatsUtil.toFieldId(fieldStats.fieldId())); |
Contributor
There was a problem hiding this comment.
I'm not sure we need the table schema for that. The stats schema should already have that information.
Essentially only GEO lower/upper fields are structs, so I think we could fetch that info from the Stats schema rather than having to pass table schema
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Materialize v4 manifest geometry and geography lower and upper bounds as GeospatialBound so callers receive the bound type, and copy reused reader instances when field stats are copied.
This is a follow-up on Ryan's review comment.