Fix truncate transform ordering comparison#3681
Open
mattfaltyn wants to merge 1 commit into
Open
Conversation
mattfaltyn
marked this pull request as ready for review
July 18, 2026 07:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3680
Rationale for this change
TruncateTransform.satisfies_order_ofaccessed the uninitialized_source_typeattribute when comparing truncate transforms with different widths, raisingAttributeErrorinstead of returning a boolean.Compare truncate widths directly, consistent with the Apache Iceberg Java implementation.
Are these changes tested?
Yes. Added regression coverage for both wider-to-narrower and narrower-to-wider comparisons.
uv run python -m pytest tests/test_transforms.py -q(283 passed)make lintmake test PYTEST_ARGS=-q(3,768 passed; 1,560 deselected)Are there any user-facing changes?
Yes. Comparing truncate transforms with different widths now returns the expected boolean instead of raising
AttributeError.