[Expr Serde] [PR 2/X] Operation type enum conversion helper #534
+337
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhjwpku
reviewed
Jan 26, 2026
| // Helper to test round-trip serialization | ||
| // Uses string comparison since expressions may have different internal identity | ||
| // but the same semantic meaning (i.e., ToString() output matches) | ||
| void TestRoundTrip(const Expression& expr) { |
Collaborator
There was a problem hiding this comment.
You add this helper function but not used anywhere.
src/iceberg/CMakeLists.txt
Outdated
| expression/expression.cc | ||
| expression/expressions.cc | ||
| expression/inclusive_metrics_evaluator.cc | ||
| expression/json_internal.cc |
Collaborator
There was a problem hiding this comment.
By convention, this file should be named json.cc, as internal is typically reserved for header files. I'm aware that we already have a json_internal.cc, but that’s legacy. I think json_serde.cc/ json_serde_internal.h would be a better choice. What do you think, @wgtmac?
evindj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a small change that will be used later. It is a simple string to enum and enum to string conversion. It does not add any functionality
Test
Added a unit tests for one of the case, just to confirm it works.
./build/src/iceberg/test/expression_test --gtest_filter="ExpressionJson*" ✔ 1322 11:28:25
Running main() from gmock_main.cc
Note: Google Test filter = ExpressionJson*
[==========] Running 3 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 3 tests from ExpressionJsonTest
[ RUN ] ExpressionJsonTest.TrueExpression
[ OK ] ExpressionJsonTest.TrueExpression (0 ms)
[ RUN ] ExpressionJsonTest.FalseExpression
[ OK ] ExpressionJsonTest.FalseExpression (0 ms)
[ RUN ] ExpressionJsonTest.OpToString
[ OK ] ExpressionJsonTest.OpToString (0 ms)
[----------] 3 tests from ExpressionJsonTest (0 ms total)
[----------] Global test environment tear-down
[==========] 3 tests from 1 test suite ran. (0 ms total)
[ PASSED ] 3 tests.