-
Notifications
You must be signed in to change notification settings - Fork 84
add-contributing-doc #521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add-contributing-doc #521
Conversation
|
I'm not sure if it is a good idea to introduce one more contributing code. We have this on our site: https://cpp.iceberg.apache.org/ and also duplicate content in the project README already. |
CONTRIBUTING.md
Outdated
| ### Local prerequisites | ||
|
|
||
| - Git | ||
| - CMake and a C++17-compatible compiler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Developers must use C++23-compatible compiler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Developers must use C++23-compatible compiler.
Updated the prerequisite to C++23-compatible compiler in CONTRIBUTING.md and pushed the change. Thanks for pointing this out!
That makes sense. |
|
There is a similar markdown file |
Yes, I think this is a better approach. |
|
I can update this PR to reuse the existing MkDocs doc as CONTRIBUTING. Move the contributing content into mkdocs/docs/CONTRIBUTING.md, Update mkdocs.yml so this file is still used as the site homepage, and (Optionally) add a thin CONTRIBUTING.md in the repo root that points to the docs if you prefer. |
|
Yes, except |
|
I’ve updated this PR to reuse the existing MkDocs doc as CONTRIBUTING: Moved the contributing guide from mkdocs/docs/index.md into mkdocs/docs/CONTRIBUTING.md. Kept mkdocs/docs/index.md as a small landing page that links to the contributing guide. Kept a thin root CONTRIBUTING.md that points to the website/docs instead of duplicating content. Please let me know if this matches the structure you had in mind. |
|
I suggest to use a softlink instead of thin markdown file. |
Adds a CONTRIBUTING.md that consolidates development environment and workflow instructions in one place.
References #329.