chore: refactor DataFileSet and make WriteManifests to use iterators #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zhjwpku
commented
Jan 20, 2026
zhjwpku
commented
- Move DataFileSet out of content_file_util.h to data_file_set.h to reduce header dependencies
- Refactor WriteDataManifests and WriteDeleteManifests to accept iterator begin/end instead of vectors
- Move DataFileSet out of content_file_util.h to data_file_set.h to reduce header dependencies - Refactor WriteDataManifests and WriteDeleteManifests to accept iterator begin/end instead of vectors
wgtmac
reviewed
Jan 20, 2026
|
|
||
| #pragma once | ||
|
|
||
| /// \file iceberg/util/data_file_set.h |
Member
There was a problem hiding this comment.
Please install it in the meson.build
| SOURCES | ||
| bucket_util_test.cc | ||
| config_test.cc | ||
| data_file_set_test.cc |
| // TODO(xxx): write manifests in parallel | ||
| template <typename Iterator> | ||
| Result<std::vector<ManifestFile>> WriteDataManifests( | ||
| const std::vector<std::shared_ptr<DataFile>>& data_files, |
Member
There was a problem hiding this comment.
Originally I suggested to use iterator because we need an extra conversion to call this function. Now I found that DataFileSet also uses std::vector internally, do you think it is better to use std::span<const std::shared_ptr<DataFile>> as the input here and add a std:span<const std::shared_ptr<DataFile>> DataFileSet::as_span() const or something similar? In this approach, we can still hide the implementation in the source file.
Collaborator
Author
There was a problem hiding this comment.
reasonable, will change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.