Skip to content

[VL] Fix GlutenRemoveRedundantSortsSuite in Spark 4.x#12497

Draft
zml1206 wants to merge 1 commit into
apache:mainfrom
zml1206:GlutenRemoveRedundantSortsSuite
Draft

[VL] Fix GlutenRemoveRedundantSortsSuite in Spark 4.x#12497
zml1206 wants to merge 1 commit into
apache:mainfrom
zml1206:GlutenRemoveRedundantSortsSuite

Conversation

@zml1206

@zml1206 zml1206 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings July 10, 2026 09:38
@github-actions github-actions Bot added the CORE works for Gluten Core label Jul 10, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Spark 4.x (Spark 4.0 and 4.1) Gluten unit tests for redundant sort removal so they validate Gluten’s columnar sort operator (SortExecTransformer) and re-enables the suite in Velox backend test settings.

Changes:

  • Rewrote GlutenRemoveRedundantSortsSuite (Spark 4.0/4.1) to assert redundant-sort behavior by counting SortExecTransformer nodes.
  • Added SparkConf override to disable forced SHJ for the suite to stabilize join-related sort expectations.
  • Enabled GlutenRemoveRedundantSortsSuite in Spark 4.0/4.1 VeloxTestSettings, including all Gluten-prefixed tests.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
gluten-ut/spark41/src/test/scala/org/apache/spark/sql/execution/GlutenRemoveRedundantSortsSuite.scala Replaces Spark SortExec-based assumptions with SortExecTransformer-based assertions for Spark 4.1.
gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala Re-enables the redundant-sorts suite for Spark 4.1 Velox UTs and includes Gluten tests.
gluten-ut/spark40/src/test/scala/org/apache/spark/sql/execution/GlutenRemoveRedundantSortsSuite.scala Same test rewrite as Spark 4.1, adapted for Spark 4.0 module.
gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala Re-enables the redundant-sorts suite for Spark 4.0 Velox UTs and includes Gluten tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +718 to +720
enableSuite[GlutenRemoveRedundantSortsSuite]
// Rewrite as it check spark SortExec.
.includeAllGlutenTests()
Comment on lines +736 to +738
enableSuite[GlutenRemoveRedundantSortsSuite]
// Rewrite as it check spark SortExec.
.includeAllGlutenTests()
@zml1206 zml1206 requested review from philo-he and zhouyuan July 13, 2026 00:52
@zml1206

zml1206 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

@zhouyuan @philo-he Should we disable tests that only verify optimization rules and are unrelated to Gluten? Examples include GlutenPlannerSuite, GlutenProjectedOrderingAndPartitioningSuite, GlutenRemoveRedundantProjectsSuite, GlutenRandomDataGeneratorSuite, GlutenSetCommandSuite, GlutenWholeStageCodegenSparkSubmitSuite, GlutenWholeStageCodegenSuite, GlutenExplainSuite, GlutenPythonDataSourceSuite, GlutenPythonUDFSuite, GlutenPythonUDTFSuite, and GlutenRowQueueSuite.

@zml1206 zml1206 marked this pull request as draft July 13, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CORE works for Gluten Core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants