refactor(dart): merge all runtime exceptions into single fory_exception.dart#3436
Merged
chaokunyang merged 2 commits intoapache:mainfrom Feb 28, 2026
Merged
refactor(dart): merge all runtime exceptions into single fory_exception.dart#3436chaokunyang merged 2 commits intoapache:mainfrom
chaokunyang merged 2 commits intoapache:mainfrom
Conversation
Collaborator
|
@yash-agarwa-l Please address conflict first |
yash-agarwa-l
force-pushed
the
merge_excep
branch
from
a8c4319 to
5cce0c3
Compare
Contributor
Author
|
Resolved and rebased to the main. |
chaokunyang
reviewed
Feb 28, 2026
| import 'package:fory/src/exception/fory_exception.dart'; | ||
| import 'package:fory/src/fory_exception.dart'; | ||
|
|
||
| abstract class ForyCodegenException extends ForyException { |
Collaborator
There was a problem hiding this comment.
Could this merged into fory_exception.dart ?
Contributor
Author
|
PTAL, They are merged now. Also I have renamed the UnsupportedTypeException of the codegen folder to CodegenUnsupportedTypeException because of a overlap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The current Dart exception hierarchy spreads runtime exceptions across four separate files under
dart/packages/fory/lib/src/exception/, which is overly Java-style for idiomatic Dart.What needs to be done?
Merge all runtime exception classes from:
exception/**codegen/exception/**into a single file:
dart/packages/fory/lib/src/fory_exception.dartUpdate all imports across serializers, resolvers, context, and codegen base to point to the new file.
Delete the
exception/subdirectory and thecodegen/exception/subdirectory.Does this introduce any user-facing change?
Related