[test] Raise disk write-limit ratio in FlussClusterExtension to avoid test flakiness#3594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #3593
The tablet server rejects writes once the data-disk usage exceeds
server.data-disk.write-limit-ratio(default0.85), and only resumes afterusage drops below
ratio - 0.10.FlussClusterExtensioninherits this default,so tests that write data through it fail with disk-write-limited errors on CI
runners or local machines whose disk usage is already above 85%. These failures
are unrelated to the code under test and make the suite flaky and
environment-dependent.
This change makes the shared test cluster ignore disk-usage protection so tests
no longer depend on the host's free disk space.
Brief change log
server.data-disk.write-limit-ratioto0.99inFlussClusterExtensionso the disk-usage write protection effectively stays out of the way during
tests, while still guarding against a truly full disk.
org.apache.curator.test.TestingServer.Tests
No new tests. This only adjusts test infrastructure. Existing tests based on
FlussClusterExtensioncontinue to pass and are no longer affected by the hostdisk-usage limit.
API and Format
No. This change is limited to test utilities and does not affect any public API
or storage format.
Documentation
No. This is a test-only change and introduces no new feature.