Repository navigation
chore(observability): pin dubbo-go to include #3770 for consumer metrics labels - #1157
Merged
Merged
Conversation
…ics labels Bump root go.mod to v3.3.3-0.20261027084029-a1aa788a3007 (merge of apache/dubbo-go#3770 on develop/main) so consumer Prometheus application_name uses the local application. Recapture signals, drop the known mismatch note, and adjust offline validation expectations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin the SDK to
v3.3.3-0.20261027084029-a1aa788a3007, the merge commit of apache/dubbo-go#3770, and regenerate the observability capture. With that fix, consumer metricapplication_nameidentifies the client and matches OTelservice.name, so the known mismatch recorded in #1155 is gone.Refs apache/dubbo-go#3767.
Why a pseudo-version
#3770 has been merged into dubbo-go
develop, but no tag contains it yet: the latest tags arev3.3.2andv3.3.2-20260910, both cut before the merge. A tagged pin would therefore still produce the mismatched capture.The pin points at the #3770 merge commit itself rather than the current
develophead, so the only runtime change pulled in beyond #3770 is what was already ondevelopbefore it. The one later commit (#3771, Nacos rule deletion callbacks) is not included. This follows the existing practice in this repository of pinningdevelopsnapshots (the previous pine4aabaf27773and #1147 are also pseudo-versions).Once a dubbo-go release containing #3770 is tagged, the pin can be switched to that tag.
Dependency changes
Only the
dubbo.apache.org/dubbo-go/v3line was edited by hand. Every other change below is the result ofgo mod tidywith the new pin:dubbo.apache.org/dubbo-go/v3v3.3.3-0.20260911014420-e4aabaf27773v3.3.3-0.20261027084029-a1aa788a3007go.opentelemetry.io/otelgo.opentelemetry.io/otel/sdkgo.opentelemetry.io/otel/tracego.opentelemetry.io/otel/metric(indirect)go.opentelemetry.io/otel/exporters/otlp/otlptrace(indirect)go.opentelemetry.io/proto/otlpgithub.com/grpc-ecosystem/grpc-gateway/v2(indirect)github.com/go-logr/logr(indirect)google.golang.org/genproto/googleapis/api(indirect)v0.0.0-20260526163538-3dc84a4a5aaav0.0.0-20260720211330-0afa2a65878agoogle.golang.org/genproto/googleapis/rpc(indirect)v0.0.0-20260622175928-b703f567277dv0.0.0-20260720211330-0afa2a65878aotlptrace/otlptracegrpc,otlptrace/otlptracehttp,stdouttraceandzipkinstay at v1.21.0 because nothing in the new module graph requires a newer version; the build and the observability integration test pass with this combination.Changes
go.mod/go.sum: new SDK pin plus the tidy result above.observability/integration/capture: regeneratedconsumer.prom,provider.prom,traces.jsonlandmanifest.json. Consumerapplication_nameis nowdubbo-observability-client. The trace capture also contains a providerWatchspan exported by the new SDK; validation does not depend on it.capture/README.md: remove the known-mismatch note.test_validate.py: the checked-in capture is now expected to pass the strict check. The negative case that corruptsapplication_nameand expects a mismatch is kept.Validation
capture.pylive capture: no field mismatches.test_validate.py: 9/9 pass../integrate_test.sh observability/integrationpasses with Go 1.25.0 (Prometheus, Jaeger and Grafana checks)..promcaptures;.licenserc.yamlunchanged.