Repository navigation
fix: EmptyCursorHolder#canVectorize must depend on the CursorBuildSpec. - #20822
Merged
Merged
Conversation
Previously, EmptyCursorHolder#canVectorize always returned true. However, the expectation for CursorHolders is that they should check the virtual columns and aggregators from the spec. Not doing so led to the vector path being taken for virtual columns and aggregators that are not able to vectorize.
clintropolis
approved these changes
Nov 3, 2026
clintropolis
left a comment
clintropolis
left a comment
Member
There was a problem hiding this comment.
Does it make a difference having a real inspector vs just always using an 'empty' signature?
Contributor
Author
I think some things can decide not to vectorize if input types aren't known. One example is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, EmptyCursorHolder#canVectorize always returned true. However, the expectation for CursorHolders is that they should check the virtual columns and aggregators from the spec. Not doing so led to the vector path being taken for virtual columns and aggregators that are not able to vectorize.