DRILL-8512: ReduceAndSimplifyFilterRule fails with NullPointerException#2944
Draft
rymarm wants to merge 1 commit intoapache:masterfrom
Draft
DRILL-8512: ReduceAndSimplifyFilterRule fails with NullPointerException#2944rymarm wants to merge 1 commit intoapache:masterfrom
rymarm wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
@jnturton I'm unsure whether the fix is correct because calcite is a black box to me, but I think I found the correct place where the change should be made. I'll be glad if you advise me on how to cover the case with unit tests. |
Contributor
You're not the only one to whom Calcite is a black box... :-) |
Member
Author
|
I saw the failing tests. I need to find another solution to solve the issue... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRILL-8512: ReduceAndSimplifyFilterRule fails with NullPointerException
Description
I'm not sure why the following issue wasn't before, but it's clear, why the issue appears at all - because we provide neither inputs
RelNodes(we callingDrillOptiq.toDrillwithnullfor the input, see code change) orRexBuilderalong withRelDataType.Testing
Tested with the query the issue was reproduced: