[fix](regression) Restore time zone after test_tz_load#65411
Open
shuke987 wants to merge 1 commit into
Open
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Collaborator
Author
|
/review |
Contributor
There was a problem hiding this comment.
Reviewed PR 65411. I did not find a correctness issue that needs an inline review comment.
Critical checkpoints:
- Scope: GitHub PR metadata shows one changed file,
regression-test/suites/datatype_p0/datetimev2/test_tz_load.groovy, at head2f6d0195a828b5f2ef39708f7948a8bff90b24ae. - Existing review context: no existing inline review comments or replies were present.
- Time zone restore: the suite now captures
@@global.time_zone, runs the existing load assertions insidetry, and restores the captured global value infinally; the Doris SET path validates normal timezone names/offsets/UTC values, and the final table cleanup is tolerant throughtry_sql. - Regression expectations: the test body and
test_tz_load.outassertions are otherwise unchanged and still match the three load cases. - User focus: no additional user-provided review focus was supplied.
- Validation: after fetching the exact base commit,
git diff --checkpassed for the reviewed base/head file range. I did not run the branch-4.0 regression suite in this runner, so runtime validation remains PR-author reported plus static review here.
Subagent conclusions:
optimizer-rewrite: no optimizer/rewrite candidate; no inline comment.tests-session-config: no tests/session/config candidate; no inline comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evidence
Testing