[improve](function) add miss proprety in show commands#65400
Open
zhangstar333 wants to merge 1 commit into
Open
[improve](function) add miss proprety in show commands#65400zhangstar333 wants to merge 1 commit into
zhangstar333 wants to merge 1 commit into
Conversation
zhangstar333
requested review from
924060929,
englefly,
morrySnow and
starocean999
as code owners
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
Author
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Automated review found one blocking issue in the Java function metadata display path.
Critical checkpoint conclusions:
- Goal: the PR intends to expose missing
STATIC_LOADmetadata in function show output. Java scalar UDF/UDAF display is covered, but Java UDTF metadata can still be displayed and replayed incorrectly. - Scope: the code change is small and focused, but it misses the parallel UDTF create path.
- Concurrency/lifecycle: no new concurrency or lifecycle concerns in the display code.
- Config/compatibility/persistence: no new config. The issue affects persisted catalog function metadata and replayed
SHOW CREATEDDL for Java UDTFs. - Parallel paths: scalar UDF and UDAF copy
isStaticLoad/expiration metadata; UDTF does not. - Tests: added unit coverage covers Java scalar UDF and UDAF display, but not the Java UDTF round trip that exposes the bug.
User focus: no additional user-provided review focus was supplied.
Subagent conclusions: optimizer-rewrite proposed OPT-1, which was accepted as MAIN-1 and submitted inline. tests-session-config reported no additional candidates. In convergence round 1, both live subagents reviewed the same current ledger/comment set and returned NO_NEW_VALUABLE_FINDINGS.
Validation note: this was a static review. The checkout is missing thirdparty/installed/bin/protoc, so FE build/tests were not run; the local base SHA is also absent, so GitHub PR file/patch metadata was used as the authoritative diff scope.
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
TPC-H: Total hot run time: 29622 ms |
Contributor
TPC-DS: Total hot run time: 180588 ms |
Contributor
ClickBench: Total hot run time: 25.12 s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
before not add STATIC_LOAD property in show create function, so user don't know this info whether have set.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)