Skip to content

[Improvement-18403][API&Security] Avoid raw password exposure in user parameter validation errors#18404

Merged
SbloodyS merged 1 commit into
apache:devfrom
njnu-seafish:Improvement-18403
Jul 10, 2026
Merged

[Improvement-18403][API&Security] Avoid raw password exposure in user parameter validation errors#18404
SbloodyS merged 1 commit into
apache:devfrom
njnu-seafish:Improvement-18403

Conversation

@njnu-seafish

Copy link
Copy Markdown
Contributor

Was this PR generated or assisted by AI?

NO

Purpose of the pull request

close #18403

Brief change log

Avoid raw password exposure in user parameter validation errors

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

@njnu-seafish

Copy link
Copy Markdown
Contributor Author

@SbloodyS I noticed some inconsistencies in the naming and placement of the test classes while looking through the code.

The service tests in the dolphinscheduler-api module currently have inconsistent naming and package placement. Most tests are placed under org.apache.dolphinscheduler.api.service, but they directly test implementation classes such as UsersServiceImpl, ProjectServiceImpl, and QueueServiceImpl. Meanwhile, a few similar tests are placed under org.apache.dolphinscheduler.api.service.impl. The class names are also inconsistent: some use the XxxServiceImplTest pattern, while most use XxxServiceTest even though they test XxxServiceImpl directly. This makes the test structure harder to navigate and maintain.

Would it be worth standardizing these tests by moving service implementation tests under api.service.impl and renaming them to XxxServiceImplTest?

PM38SQJQO`A$)P6M`F3_WS4

@SbloodyS SbloodyS added the improvement make more easy to user or prompt friendly label Jul 10, 2026
@SbloodyS SbloodyS added this to the 3.5.0 milestone Jul 10, 2026
@SbloodyS

Copy link
Copy Markdown
Member

These don't need to be modified for the time being. @njnu-seafish

@SbloodyS SbloodyS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@njnu-seafish

Copy link
Copy Markdown
Contributor Author

These don't need to be modified for the time being

ok

@SbloodyS SbloodyS merged commit e12fa9d into apache:dev Jul 10, 2026
120 of 121 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend improvement make more easy to user or prompt friendly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement][API&Security] Avoid raw password exposure in user parameter validation errors

2 participants