You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@SbloodyS I noticed some inconsistencies in the naming and placement of the test classes while looking through the code.
The service tests in the dolphinscheduler-api module currently have inconsistent naming and package placement. Most tests are placed under org.apache.dolphinscheduler.api.service, but they directly test implementation classes such as UsersServiceImpl, ProjectServiceImpl, and QueueServiceImpl. Meanwhile, a few similar tests are placed under org.apache.dolphinscheduler.api.service.impl. The class names are also inconsistent: some use the XxxServiceImplTest pattern, while most use XxxServiceTest even though they test XxxServiceImpl directly. This makes the test structure harder to navigate and maintain.
Would it be worth standardizing these tests by moving service implementation tests under api.service.impl and renaming them to XxxServiceImplTest?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was this PR generated or assisted by AI?
NO
Purpose of the pull request
close #18403
Brief change log
Avoid raw password exposure in user parameter validation errors
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md