[DSIP-89][Task] Render SQL parameters before statement execution#18398
Open
qiuyanjun888 wants to merge 1 commit into
Open
[DSIP-89][Task] Render SQL parameters before statement execution#18398qiuyanjun888 wants to merge 1 commit into
qiuyanjun888 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was this PR generated or assisted by AI?
YES. This pull request was assisted by Hermes Agent / OpenAI Codex for code changes, focused tests, documentation updates, and local verification. The scope and final submission were directed by the contributor.
Purpose of the pull request
Fix #17263.
Render SQL task custom parameters locally before submitting SQL through JDBC
Statement, avoidingPreparedStatementfor SQL text that already contains DolphinScheduler parameter syntax.This pull request supersedes #18396, which was closed because the original description did not include the AI-assistance declaration required by the current pull request template.
Brief change log
${name}and!{name}placeholders.${name}placeholders as SQL literals by default, including escaping string-like values and validating typed literals.!{name}replacement for trusted SQL fragments without rescanning rendered replacement text.Statementto execute rendered SQL inSqlTask.Verify this pull request
This change added tests and can be verified as follows:
./mvnw -pl dolphinscheduler-task-plugin/dolphinscheduler-task-sql -am -DskipUT=false -DskipITs -DskipE2E -Dcheckstyle.skip -Dspotless.check.skip -Djacoco.skip=true -Dsurefire.failIfNoSpecifiedTests=false -Dtest=SqlTaskTest test./mvnw -pl dolphinscheduler-task-plugin/dolphinscheduler-task-sql -am spotless:applygit diff --checkPull Request Notice
Pull Request Notice