chore: gate Parquet opener encryption on parquet_encryption - #25907
Open
neilconway wants to merge 1 commit into
Open
neilconway wants to merge 1 commit into
neilconway wants to merge 1 commit into
Conversation
Without the `parquet_encryption` feature, clippy fails on a dead stub in
`opener/encryption.rs` (`clippy::unused_async_trait_impl`). For example:
cargo clippy -p datafusion-datasource-parquet --all-targets -- -D warnings
Every use of the module is already gated on the feature, so gate the
module itself and remove the stubs. CI doesn't catch this because its
`--workspace` build enables the feature.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25907 +/- ##
==========================================
- Coverage 82.60% 82.60% -0.01%
==========================================
Files 1144 1144
Lines 441971 441971
Branches 441971 441971
==========================================
- Hits 365081 365073 -8
- Misses 54807 54814 +7
- Partials 22083 22084 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Without the
parquet_encryptionfeature, clippy fails on a dead stub inopener/encryption.rs(clippy::unused_async_trait_impl). For example:Every use of the module is already gated on the feature, so gate the module itself and remove the stubs. CI doesn't catch this because its
--workspacebuild enables the feature.What changes are included in this PR?
See above.
What is the testing strategy for this PR?
Tests pass,
clippycommand above now passes without warnings.Are there any user-facing changes?
No.