feat(datafusion-spark): implement spark compatible unhex function
#19909
+637
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefffrey
reviewed
Jan 21, 2026
|
|
||
| Self { | ||
| signature: Signature::coercible(vec![string], Volatility::Immutable), | ||
| aliases: vec![], |
Contributor
There was a problem hiding this comment.
Remove aliases if there are none
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { |
Contributor
There was a problem hiding this comment.
Can we move all these tests to SLTs?
| } | ||
| } | ||
|
|
||
| pub fn spark_unhex(args: &[ColumnarValue]) -> Result<ColumnarValue, DataFusionError> { |
Contributor
There was a problem hiding this comment.
This doesn't need to be pub
Comment on lines
+155
to
+157
| if args.len() != 1 { | ||
| return exec_err!("unhex tasks exactly 1 argument, but got: {}", args.len()); | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| if args.len() != 1 { | |
| return exec_err!("unhex tasks exactly 1 argument, but got: {}", args.len()); | |
| } | |
| let arg = take_function_args("unhex", &args.args)?; |
| I: Iterator<Item = Option<T>>, | ||
| T: AsRef<str>, | ||
| { | ||
| let mut builder = BinaryBuilder::with_capacity(len, len * 32); |
| } | ||
| } | ||
|
|
||
| fn unhex_common(bytes: &[u8], out: &mut Vec<u8>) -> bool { |
Contributor
There was a problem hiding this comment.
Might be good to leave a simple comment on the function explaining the outputs (writes into out, returns boolean indicating if valid or not)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of: #15914
Rationale for this change
Implement spark compatible unhex functions:
https://spark.apache.org/docs/latest/api/sql/index.html#unhex
What changes are included in this PR?
Are these changes tested?
Yes. UTs and SLT added.
Are there any user-facing changes?
No.