Dialects: implement identifier_quote_style for remaining dialect#2401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dialect::identifier_quote_stylereturned the defaultNonefor most dialects even when the database has a documented identifier quote character.For example
SnowflakeDialect {}.identifier_quote_style("id")returnedNone, so downstream SQL generators could not tell how to quote identifiers for these dialects.This PR implements the method for the remaining dialects: backticks for BigQuery, ClickHouse, Databricks, Hive and Spark, and double quotes for ANSI, DuckDB, Redshift and Snowflake, each with a reference to the database's documentation.
GenericDialectintentionally keeps returningNonesince it does not assume any specific database.The existing unit test in
src/dialect/mod.rsis extended to cover all dialects.