Snowflake: parse CREATE WAREHOUSE#2388
Open
sabir-akhadov-localstack wants to merge 2 commits into
Open
Conversation
Add `Statement::CreateWarehouse` and `ObjectType::Warehouse` so the parser accepts `CREATE [OR REPLACE] WAREHOUSE [IF NOT EXISTS] <name>` with optional warehouse properties/parameters, plus `DROP WAREHOUSE`. Warehouse options are captured as `KeyValueOptions` so the statement round-trips losslessly instead of discarding everything after the name. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
iffyio
reviewed
Jul 14, 2026
Comment on lines
+4545
to
+4554
| CreateWarehouse { | ||
| /// `OR REPLACE` flag. | ||
| or_replace: bool, | ||
| /// `IF NOT EXISTS` flag. | ||
| if_not_exists: bool, | ||
| /// Warehouse name. | ||
| name: ObjectName, | ||
| /// Warehouse properties and parameters (e.g. `WAREHOUSE_SIZE = 'XSMALL'`). | ||
| options: KeyValueOptions, | ||
| }, |
Contributor
There was a problem hiding this comment.
Can we change the representation to use a named struct? i.e. CreateWarehouse(CreateWarehouse)
Contributor
Author
There was a problem hiding this comment.
Done in 3fc58f5 — moved to a named CreateWarehouse struct following the CreateUser pattern (struct + Display + From<CreateWarehouse> for Statement).
Address review feedback: change the inline-field variant to CreateWarehouse(CreateWarehouse), following the CreateUser pattern. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
sabir-akhadov-localstack
added a commit
to localstack/datafusion-sqlparser-rs
that referenced
this pull request
Jul 14, 2026
Follow the upstream convention requested on apache#2388: Statement variants wrap a named struct (CreateExternalVolume, AlterExternalVolume, DescribeExternalVolume, ShowExternalVolumes) instead of inline fields. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snowflake supports
CREATE WAREHOUSEto provision a virtual warehouse, andDROP WAREHOUSEto remove one. Neither parsed before this change.This adds
Statement::CreateWarehouseandObjectType::Warehouse. The warehouse properties and parameters are captured asKeyValueOptions(the same representation used forCREATE FILE FORMATand friends), so the statement round-trips losslessly rather than discarding everything after the name. The optional leadingWITHand the spaces around=are normalized away on display.See the Snowflake
CREATE WAREHOUSEdocs.