Replace usage of with await lock (asyncio reactor broken in Python 3.9+)#1270
Open
ramikg wants to merge 1 commit intoapache:trunkfrom
Open
Replace usage of with await lock (asyncio reactor broken in Python 3.9+)#1270ramikg wants to merge 1 commit intoapache:trunkfrom
with await lock (asyncio reactor broken in Python 3.9+)#1270ramikg wants to merge 1 commit intoapache:trunkfrom
Conversation
ramikg
changed the title
with await lockwith await lock
ramikg
changed the title
with await lockwith await lock (asyncio reactor broken in Python 3.9+)
Contributor
|
Yup, this looks right to me. Syntax was changed in Python 3.9 so all the versions we're planning on covering for 3.30.0 should be fine with this change. I'm going to kick off a CI run to confirm there aren't any other unexpected regressions here but I think this should work just as it sits. Nice find @ramikg! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to connect to Cassandra using the
asyncioreactor times out in Python 3.9+.This is because pushing messages to the queue silently fails due to the usage of the
with await asyncio.Locksyntax, removed in Python 3.9.I've replaced it with
async with lock(as suggested by the docs), and now it works.