Skip to content

rename TestRecord - #40728

Merged
Abacn merged 1 commit into
apache:masterfrom
aIbrahiim:rename-test-record
Oct 22, 2026
Merged

Abacn merged 1 commit into
apache:masterfrom
aIbrahiim:rename-test-record

Conversation

@aIbrahiim

Copy link
Copy Markdown
Contributor

PreCommit SQL Java17 and The PostCommit Java Examples Dataflow ARM are red because ErrorProne JavaLangClash hits the nested test class named Record which clashes with java.lang.Record so this PR renamed it to TestRecord / TestRecordCoder in CoderTranslationTest so the name stays in the same coder test context but avoids the clash
Fixes #39472 and #31901

@github-actions github-actions Bot added the java label Oct 22, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR renames the nested test classes Record and RecordCoder to TestRecord and TestRecordCoder in CoderTranslationTest to resolve an ErrorProne JavaLangClash violation with java.lang.Record on Java 17+. The change is clean, minimal, and safe to merge.

🔍 General Feedback

  • All references to Record and RecordCoder within CoderTranslationTest have been consistently updated, preserving test behavior without any unintended side effects.

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

@aIbrahiim

Copy link
Copy Markdown
Contributor Author

cc: @ahmedabu98

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @damccorm for label java.
Backup reviewer: Abacn (if the main reviewer is unresponsive, you can escalate to them by tagging their username)

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@codecov

codecov Bot commented Oct 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.04%. Comparing base (a8d6afd) to head (d206f37).
⚠️ Report is 35 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #40728   +/-   ##
=======================================
  Coverage   80.04%   80.04%           
=======================================
  Files         490      490           
  Lines       82916    82910    -6     
=======================================
- Hits        66373    66369    -4     
+ Misses      16543    16541    -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Abacn
Abacn merged commit f5f6006 into apache:master Oct 22, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PreCommit SQL Java17 job is flaky

2 participants