Repository navigation
rename TestRecord - #40728
rename TestRecord#40728
Conversation
There was a problem hiding this comment.
📋 Review Summary
This PR renames the nested test classes Record and RecordCoder to TestRecord and TestRecordCoder in CoderTranslationTest to resolve an ErrorProne JavaLangClash violation with java.lang.Record on Java 17+. The change is clean, minimal, and safe to merge.
🔍 General Feedback
- All references to
RecordandRecordCoderwithinCoderTranslationTesthave been consistently updated, preserving test behavior without any unintended side effects.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
|
cc: @ahmedabu98 |
|
Assigning reviewers: R: @damccorm for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40728 +/- ##
=======================================
Coverage 80.04% 80.04%
=======================================
Files 490 490
Lines 82916 82910 -6
=======================================
- Hits 66373 66369 -4
+ Misses 16543 16541 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
PreCommit SQL Java17 and The PostCommit Java Examples Dataflow ARM are red because ErrorProne JavaLangClash hits the nested test class named Record which clashes with java.lang.Record so this PR renamed it to TestRecord / TestRecordCoder in CoderTranslationTest so the name stays in the same coder test context but avoids the clash
Fixes #39472 and #31901