Add dill dep where tensorflow-transform is used.#36158
Add dill dep where tensorflow-transform is used.#36158liferoad merged 1 commit intoapache:masterfrom
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @claudevdm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a crucial dependency fix by explicitly adding the dill package to the project's setup.py where tensorflow-transform is utilized. This resolves a runtime issue stemming from tensorflow-transform's undeclared dependency on dill, which was previously satisfied transitively through apache-beam. With apache-beam no longer including dill, this change ensures the continued functionality of tensorflow-transform components until an upstream fix is released.
Highlights
- Dependency Management: Explicitly adds 'dill' as a dependency in
sdks/python/setup.pyfor components utilizingtensorflow-transform. - Resolving Missing Dependency: Addresses an issue where
tensorflow-transformimplicitly relies ondillbut does not declare it, which became problematic afterapache-beamremoved its transitivedilldependency. - Temporary Fix: This change is a temporary workaround until the
tensorflow-transformproject officially includesdillin its ownsetup.py.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
R: @liferoad |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
tensorflow-transform has a hard dependency on dill but does not specify it in setup.py. It used to be included transitively by depending on apache-beam, but apache-beam no longer has a hard dependency on dill.
This adds dill as a dep temporarily where tensorflow-transform is used until tensorflow/transform#345 is released
#32603
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.