GH-49112: [C++] Support half-float tensors in equality comparison #49113
+79
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
commented
Feb 2, 2026
| std::vector<int64_t> shape = {4, 4}; | ||
|
|
||
| std::vector<c_data_type> c_values = {1, 2, 3, 4, 5, 6, 7, 8, | ||
| constexpr int c_vals_as_int_arr[] = {1, 2, 3, 4, 5, 6, 7, 8, |
Member
Author
There was a problem hiding this comment.
The variable name is a bit lengthty. Intentionally matched the line length to match with its previous length (so the next line doesn't need the diff). I can change the variable name :-).
github-actions
bot
added
awaiting committer review
HyukjinKwon
force-pushed
the
GH-49112
branch
2 times, most recently
from
6b1f2f5 to
c88b7a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Half-float tensor equality comparison was not implemented. The TODO comment indicated this was missing functionality. Array/Scalar equality for half-float was already fixed in 72d20ad. This PR completes the support by adding tensor comparison.
What changes are included in this PR?
HALF_FLOATcase toTensorEquals()and sparse tensor comparison functionsTestFloatTensorforHalfFloatTypestatic_assertto allowHalfFloatTypein tensor comparison templatesAre these changes tested?
Yes,
TestFloatTensor::Equals.Are there any user-facing changes?
Yes, users can now compare half-float tensors using
Tensor::Equals().