Repository navigation
fix: Update amqp to honor the transportConnector flags for clientAuth - #2756
Merged
Merged
Conversation
Contributor
|
Looks good and it's a great fix. Because this will prevent previous clients without certificat to connect with needClientAuth because it was not honored previously, we need to make it clear in the release notes I think. In the test, the result of the createConnection() should be assigned to the connection of the parent maybe so the tearDown() can close it. Nothing important or critical. Is there a negative test that basically asserts that a client without a valid certificate is now rejected? Is there any back port you plan to do on other branches? |
The amqp+nio+ssl connector should request the client certificate when the connector URI sets needClientAuth or wantClientAuth in the bare form, matching the openwire, stomp and mqtt nio+ssl connectors and the amqp+ssl blocking connector. amqp+nio+ssl builds a plain TcpTransportServer that only applies transport.-prefixed options, so the bare form is dropped and the certificate is never requested. testClientCertificateRequested fails for both bare needClientAuth and bare wantClientAuth until the fix in the next commit.
AmqpNioSslTransportFactory built a plain TcpTransportServer, which only applies transport.-prefixed connector options, so bare needClientAuth/wantClientAuth were dropped and the client certificate was never requested. Build a NIOSSLTransportServer and set needClientAuth/wantClientAuth on the transport in createTransport, matching StompNIOSSLTransportFactory and MQTTNIOSSLTransportFactory. transport.-prefixed options continue to work.
mattrpav
force-pushed
the
amq-amqp-nio-ssl-clientauth
branch
from
October 28, 2026 14:51
c297178 to
dc91ce4
Compare
github-project-automation
Bot
moved this from In review
to Done
in Apache ActiveMQ v6.5.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
amqp transport does not honor these config flags on the transport connector like the other transports