fix(skill): remove the three places the guidance undercut its own traffic rule (codex) - #34
Merged
Merged
Conversation
…rule (codex)
- SKILL.md let an APM edge inside max_age_hours support a present-tense traffic
verdict. That option filters accumulated observations: a single request 23
hours ago passes a 24-hour window. Only a live read supports the claim.
- The reverse exposure recipe said it answers how traffic reaches a workload
today. It walks structural edges between :ALIVE nodes, which this same change
defines as undeleted, so it describes a declared route.
- The inventory recipe counted an EXPOSES edge to an :ALIVE pod as a live
backend, while EXPOSES deliberately keeps not-ready endpoints as
{ready:false}. Renamed to withPodEdge and a withReadyEndpoint column added
that reads the readiness the endpoint slice last reported.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
@codex review |
lerenn
approved these changes
Sep 18, 2026
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #33, which auto-merged before these review fixes were pushed. All three are places the previous change contradicted itself.
max_age_hourssupport a present-tense traffic verdict. That option filters accumulated observations: a single request 23 hours ago passes a 24-hour window and still says nothing about now. Only a live read supports the claim.:ALIVEnodes, which the same change defines as undeleted — so it describes a declared route.EXPOSESedge to an:ALIVEpod as a live backend, whileEXPOSESdeliberately keeps not-ready endpoints as{ready:false}. Renamed towithPodEdge, with awithReadyEndpointcolumn that reads the readiness the endpoint slice last reported.🤖 Generated with Claude Code