-
Notifications
You must be signed in to change notification settings - Fork 61
fix: disable sourcemaps for ESM output #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v5
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @yvonneyx, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a minor version update and a build configuration adjustment. The primary goal appears to be preparing for a new beta release by bumping the package version and optimizing the build output by disabling sourcemaps for ESM modules, potentially reducing file sizes or simplifying the distribution of these specific builds. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request bumps the package version and disables sourcemap generation for the ESM builds (lib directory). While this might seem like a way to reduce package size, it negatively impacts the developer experience for users of this library, as it makes debugging much more difficult. My review includes suggestions to re-enable sourcemaps for the ESM outputs to ensure a better debugging experience for consumers.
| dir: 'lib', | ||
| format: 'esm', | ||
| sourcemap: true, | ||
| sourcemap: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disabling sourcemaps for the ESM build (lib directory) will make it more difficult for developers using this library to debug issues, as they won't be able to step through the original TypeScript source code. It is highly recommended to keep sourcemaps enabled for library builds to improve the developer experience for consumers. The impact on final bundle size for end-users is typically negligible, as bundlers usually strip sourcemaps for production builds.
| sourcemap: false, | |
| sourcemap: true, |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v5 #286 +/- ##
=======================================
Coverage 86.12% 86.12%
=======================================
Files 77 77
Lines 5938 5938
Branches 1440 1411 -29
=======================================
Hits 5114 5114
Misses 823 823
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.