Repository navigation
fix(resource): exclude inline payloads from fallback searches - #269
Open
cangen185-sudo wants to merge 1 commit into
Open
cangen185-sudo wants to merge 1 commit into
cangen185-sudo wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failed inline SVG/image resources currently use their raw payload as an icon-search query.
getFallbackQuery()returnscfg.databefore reaching its existing inline/data-URI/SVG exclusions, so an item label, description, or the defaulticon/illustrationquery is never selected for nonempty inline data.Apply those exclusions before accepting the configured query. Preserve the current priority of searchable configuration text, including bare icon names such as
plane; only fall back to the item context and scene default when the configured data is excluded or empty. Successful primary loading is unchanged.Validation on main
5ae0d9394ac6280cb688eb4b4345881e291b9209:loadResource; the original code fails 8 and passes 3, while the patch passes all 11.npm run build:esm,npm run check:test, and ESLint/Prettier on the two changed files passed.This PR was prepared with AI assistance. Local validation used Windows and Node.js 24; the repository's macOS/Node.js 20 CI remains the remote validation boundary.