Skip to content

fix(live-editor): disable share and URL content loading to prevent XSS - #266

Merged
Aarebecca merged 1 commit into
mainfrom
fix/remove-url-share-xss
Oct 19, 2026
Merged

Aarebecca merged 1 commit into
mainfrom
fix/remove-url-share-xss

Conversation

@Aarebecca

Copy link
Copy Markdown
Contributor

Summary

This PR disables loading editor content from the URL content parameter and removes sharing capability that wrote content back into the URL. These features can be abused to inject executable content and lead to XSS vulnerabilities. The changes are minimal and intended to quickly remove the attack surface.

Changes

  • Remove reading content from query parameters when mounting Live Editor.
  • Remove writing editor content back to URL when editing.
  • Remove the share button from the editor UI.
  • Keep compress/decompress helpers but disable generateShareUrl and extractContentFromUrl to avoid breaking other imports.

@Aarebecca
Aarebecca force-pushed the fix/remove-url-share-xss branch from 982943d to 0589a94 Compare October 19, 2026 12:46
@Aarebecca
Aarebecca merged commit 57c6df5 into main Oct 19, 2026
3 checks passed
@Aarebecca
Aarebecca deleted the fix/remove-url-share-xss branch October 19, 2026 13:11
@hustcc
hustcc restored the fix/remove-url-share-xss branch October 19, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant