Skip to content

Convert a number or boolean argument with asString in four string functions #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhengchun merged 1 commit into from
Sep 27, 2026
Merged

Convert a number or boolean argument with asString in four string functions #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions func.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,6 +436,8 @@ func matchesFunc(arg1, arg2 query) func(query, iterator) interface{} {
return false
}
s = node.Value()
default:
s = asString(t, typ)
}
var pattern string
var ok bool
Expand Down Expand Up @@ -463,6 +465,8 @@ func normalizespaceFunc(arg1 query) func(query, iterator) interface{} {
return ""
}
m = node.Value()
default:
m = asString(t, typ)
}
var b = builderPool.Get().(stringBuilder)
b.Grow(len(m))
Expand Down Expand Up @@ -500,6 +504,8 @@ func substringFunc(arg1, arg2, arg3 query) func(query, iterator) interface{} {
return ""
}
m = node.Value()
default:
m = asString(t, typ)
}

var start, length float64
Expand Down Expand Up @@ -588,6 +594,8 @@ func stringLengthFunc(arg1 query) func(query, iterator) interface{} {
break
}
return float64(utf8.RuneCountInString(node.Value()))
default:
return float64(utf8.RuneCountInString(asString(t, v)))
}
return float64(0)
}
Expand Down
7 changes: 7 additions & 0 deletions xpath_function_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,8 @@ func Test_func_string_length(t *testing.T) {
// characters, not bytes (REC 4.2)
test_xpath_eval(t, empty_example, `string-length("héllo")`, float64(5))
test_xpath_eval(t, empty_example, `string-length("日本語")`, float64(3))
test_xpath_eval(t, empty_example, `string-length(12345)`, float64(5))
test_xpath_eval(t, empty_example, `string-length(true())`, float64(4))
}

func Test_func_substring(t *testing.T) {
Expand All @@ -180,6 +182,8 @@ func Test_func_substring(t *testing.T) {
test_xpath_eval(t, empty_example, `substring("12345", 0, 1)`, "")
test_xpath_eval(t, empty_example, `substring("12345", 0, 2)`, "1")
test_xpath_eval(t, empty_example, `substring("12345", 0, 3)`, "12")
test_xpath_eval(t, empty_example, `substring(12345, 2, 3)`, "234")
test_xpath_eval(t, empty_example, `substring(1 div 0, 1, 3)`, "Inf")
test_xpath_eval(t, empty_example, `substring("12345", 0, 5)`, "1234")
test_xpath_eval(t, empty_example, `substring("12345", -1, 4)`, "12")
test_xpath_eval(t, empty_example, `substring("12345", -2, 5)`, "12")
Expand Down Expand Up @@ -246,6 +250,7 @@ func Test_func_translate(t *testing.T) {

func Test_func_matches(t *testing.T) {
test_xpath_eval(t, empty_example, `matches("abracadabra", "bra")`, true)
test_xpath_eval(t, empty_example, `matches(123, "^123$")`, true)
test_xpath_eval(t, empty_example, `matches("abracadabra", "(?i)^A.*A$")`, true)
test_xpath_eval(t, empty_example, `matches("abracadabra", "^a.*a$")`, true)
test_xpath_eval(t, empty_example, `matches("abracadabra", "^bra")`, false)
Expand Down Expand Up @@ -366,6 +371,8 @@ func Test_func_normalize_space(t *testing.T) {
const expectedStr = `loooooooonnnnnnngggggggg tes t strin g`
test_xpath_eval(t, empty_example, `normalize-space("`+testStr+`")`, expectedStr)
test_xpath_eval(t, empty_example, `normalize-space(' abc ')`, "abc")
test_xpath_eval(t, empty_example, `normalize-space(12)`, "12")
test_xpath_eval(t, empty_example, `normalize-space(false())`, "false")
n := selectNode(employee_example, `//employee[@id="1"]/name`)
test_xpath_eval(t, n, `normalize-space()`, "Opal Kole")
test_xpath_eval(t, n, `normalize-space(.)`, "Opal Kole")
Expand Down
Loading