Skip to content

Fix chained predicates on a filter expression #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhengchun merged 2 commits into from
Sep 25, 2026
Merged

Fix chained predicates on a filter expression #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bed28f
test: add failing test for chained predicate on a grouped expression
dastrobu Sep 23, 2026
063ed74
parse: loop over predicates in parseFilterExpr
dastrobu Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion parse.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ func (p *parser) parsePathExpr(n node) node {
// FilterExpr ::= PrimaryExpr | FilterExpr Predicate
func (p *parser) parseFilterExpr(n node) node {
opnd := p.parsePrimaryExpr(n)
if p.r.typ == itemLBracket {
for p.r.typ == itemLBracket {
opnd = newFilterNode(opnd, p.parsePredicate(opnd))
}
return opnd
Expand Down
9 changes: 9 additions & 0 deletions xpath_predicate_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,3 +99,12 @@ func TestNestedPredicates(t *testing.T) {
test_xpath_elements(t, employee_example, `//employee[./name[@from]]`, 8)
test_xpath_elements(t, employee_example, `//employee[.//name[@from = "CA"]]`, 8)
}

func TestChainedPredicateOnGroupedExpression(t *testing.T) {
test_xpath_count(t, employee_example, `(//employee)[1][false()]`, 0)
test_xpath_count(t, employee_example, `(//employee)[2][false()]`, 0)
test_xpath_count(t, employee_example, `(//employee)[1][@id = "2"]`, 0)
test_xpath_elements(t, employee_example, `(//employee)[1][true()]`, 3)
test_xpath_elements(t, employee_example, `(//employee)[1][@id = "1"]`, 3)
test_xpath_elements(t, employee_example, `(//employee)[2][@id = "2"]`, 8)
}