fix : fix the bug located in colormap for displaying graphics#672
Draft
mayankansys wants to merge 2 commits intomainfrom
Draft
fix : fix the bug located in colormap for displaying graphics#672mayankansys wants to merge 2 commits intomainfrom
mayankansys wants to merge 2 commits intomainfrom
Conversation
2 tasks
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Pull request overview
This PR fixes colormap display in graphics by hoisting clean_field computation and setting scalar_bar_args["title"] earlier, and updates the example script to pass required solver parameters.
Changes:
- Moves
clean_field = field.replace("\n", " ")to the top of_display_vector,_display_pathlines, and_display_contour, removing duplicate computations, and setsscalar_bar_args["title"]to fix colormap title display. - Updates example script to pass
solver=solver_sessionandsettings_source=solver_sessionto graphics objects, and addsui_mode="gui".
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/ansys/fluent/visualization/graphics/graphics_windows_manager.py |
Deduplicates clean_field computation and sets scalar bar title earlier to fix colormap display |
examples/00-post_processing/post_processing_context_manager.py |
Adds required solver and settings_source parameters to graphics object constructors |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+307
to
+310
| try: | ||
| scalar_bar_args["title"] = clean_field | ||
| except (NameError, UnboundLocalError): | ||
| pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.