fix(tui): sort child sessions by created time, not session ID - #42907
Open
Zagoshipda wants to merge 1 commit into
Open
fix(tui): sort child sessions by created time, not session ID#42907Zagoshipda wants to merge 1 commit into
Zagoshipda wants to merge 1 commit into
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential duplicate PR found:
|
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #42905
Type of change
What does this PR do?
session.child.first(Ctrl+X+Down) and the Left/Right child cycle sorted sibling sessions by session ID string. Session IDs are descending-encoded timestamps that wrap around at 2^48, so once the encoding wraps the ID order no longer matches creation order and "first child" lands on an old subagent instead of the newest.The fix sorts
children()inpackages/tui/src/routes/session/index.tsxbytime.createddescending instead of by session ID. This is the ordering the ID sort was already encoding — "first child" keeps meaning newest-created, but is now stable across the wrap. The footer(N of M)counter already sorts bytime.createdascending, so navigation and the counter stay consistent (Ctrl+X+Down lands onM of M).How did you verify your code works?
~currentwherecurrent = timestamp_ms * 0x1000 + counter, truncated to 48 bits. The last wrap occurred at 2026-08-14 11:19:55 UTC.bun typecheckpasses inpackages/tui.Screenshots / recordings
Not included — this changes which session navigation lands on, not how the UI looks, so there is nothing visual to capture.
Checklist