fix(session-ui): prevent variant select overlap on mobile - #42833
Open
Xieweikang123 wants to merge 1 commit into
Open
fix(session-ui): prevent variant select overlap on mobile#42833Xieweikang123 wants to merge 1 commit into
Xieweikang123 wants to merge 1 commit into
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #42834
Type of change
What does this PR do?
On mobile/narrow viewports (320-390px), the reasoning-effort (variant) select in the v2 prompt input overlapped the send button, making the "thinking strength" option unclickable.
In the prompt-input DockTray, the attach/model/variant selects live inside a
flex min-w-0 flex-1container. Their wrappingTooltipV2/menu layers defaulted tomin-width: auto, so they could not shrink. On narrow screens the variant select overflowed onto the fixed send button (which sits outside the flex container) and was visually hidden/covered.3 small class changes in
packages/session-ui/src/v2/components/prompt-input/index.tsx:[&>*]:min-w-0to the tray's flex container so every direct child can shrinkmin-w-0to thePromptInputV2Selecttooltip wrappermin-w-0to the select trigger button (complements existingmax-w-[220px])How did you verify your code works?
Verified at 320/360/375/390px widths: no overlap; model select shrinks (220→~177px) and variant select stays fully visible.
Screenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist