Skip to content

Fix clean-install permission loading loop#1825

Merged
anilbeesetti merged 1 commit into
mainfrom
codex/fix-issue-1820-permission-loop
Jul 19, 2026
Merged

Fix clean-install permission loading loop#1825
anilbeesetti merged 1 commit into
mainfrom
codex/fix-issue-1820-permission-loop

Conversation

@anilbeesetti

Copy link
Copy Markdown
Owner

Summary

  • show the storage permission flow before media loading state can block it
  • start media collection when permission changes from denied to granted, including grants from Android Settings
  • add Android 16 Robolectric regressions for clean installs and Settings-return grants

Reproduction

On a fresh install without READ_MEDIA_VIDEO, MediaPickerViewModel correctly waits for permission and remains in DataState.Loading. The permission UI was nested under DataState.Success, so the app displayed an endless spinner and could never request the permission needed to leave Loading.

Testing

  • ./gradlew :feature:videopicker:testDebugUnitTest
  • ./gradlew :feature:videopicker:ktlintCheck
  • ./gradlew :app:compileDebugKotlin
  • clean-install flow verified on an isolated Android 16 emulator: permission prompt displayed, grant opened the media library, and crash log remained empty

Closes #1820

@anilbeesetti
anilbeesetti merged commit b2875cc into main Jul 19, 2026
1 check passed
@anilbeesetti
anilbeesetti deleted the codex/fix-issue-1820-permission-loop branch July 19, 2026 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0.17.2 has a never ending spinning circle on a new install

1 participant